Skip to content

Trivial #3016 followups #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

No description provided.

e41e756 removed
`ChannelManager::send_payment_with_route` due to a rebase error as
it was originally written when `send_payment_with_route` had been
made test-only.

Here we restore it to be public.
e41e756 introduced some
indentation errors that we fix here.
e41e756 started exposing some
tests but left some functions as non-pub that were now pub (though
it doesn't actually matter as we expose the function pointers
directly via `inventory).
@TheBlueMatt TheBlueMatt added this to the 0.2 milestone Mar 4, 2025
@TheBlueMatt TheBlueMatt requested a review from wpaulino March 4, 2025 16:24
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Mar 4, 2025

👋 Thanks for assigning @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@wpaulino wpaulino mentioned this pull request Mar 4, 2025
@devrandom
Copy link
Member

thank you for the fixes!

@TheBlueMatt TheBlueMatt merged commit 7188d5b into lightningdevkit:main Mar 4, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants